NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

All changes from Nick

Open nick-knowles opened this issue 8 months ago • 8 comments

The ENTRANCE TYPE SHould be abstract - use concrte subtype STOP PLACE ENTRANCE etc

#892 #891 https://github.com/NeTEx-CEN/NeTEx/pull/888 Access conditions for passenger vehicles onboard Tmlign Add max poer to parking #887 Access conditions for passenger vehicles onboard TM ALignment DECK PLANS Add type of deck entrance usage to DECK ENTRANCE USAGE #886 Add max power to parking https://github.com/NeTEx-CEN/NeTEx/pull/885 Fix correct powered train & unpowered train https://github.com/NeTEx-CEN/NeTEx/pull/884 add SPOT ALLOCATIOn elements and update examples https://github.com/NeTEx-CEN/NeTEx/pull/881 Fixing an enum https://github.com/NeTEx-CEN/NeTEx/pull/880 Add FarePrice Frame

nick-knowles avatar May 01 '25 13:05 nick-knowles

Given the very detailed modelling including the definition of wheelchair types, I had a look at the AccessibilityAssessment. In Deck-Plans-Example_trains.xml I found WheelchairAccess == true together with StepFreeAccess == false. This is an invalid combination - according to the definition in EPIAP wheelchair access has step-free access as precondition.

@nick-knowles What kind of wheelchair access should be modelled? Everything step-free such that it would suffice to change StepFreeAccess to true? Or the more complicated case that only accompanied wheelchair is possible or assistance is available to overcome steps?

trurlurl avatar May 05 '25 14:05 trurlurl

@skinkie pls make sure that it is mergable again. I think this comes from your latest merge

ue71603 avatar May 06 '25 14:05 ue71603

I'll resolve conflicts.

skinkie avatar May 06 '25 14:05 skinkie

But like with the other work already done this pull requests breaks it.

skinkie avatar May 06 '25 14:05 skinkie

I know. That's why I would have prefered to merge this one first. Yours was partially automatised, so I hoped it would be easier to update.

ue71603 avatar May 06 '25 14:05 ue71603

Make sure that all files validate. Changes were made to files that were not checked in xmllint.

@skinkie thanks for the adaptions. I fixed something from validating the whole example folder in xml spy. Should be good to go now.

ue71603 avatar May 06 '25 22:05 ue71603

@trurlurl fixed the AccessibilityLimitation

ue71603 avatar May 06 '25 22:05 ue71603

hmm still full of problems... https://github.com/nick-knowles/NeTEx/actions/runs/14870614418/job/41757999865

ue71603 avatar May 06 '25 22:05 ue71603