NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

Remove all unreferenced groups, complexTypes, simpleTypes

Open skinkie opened this issue 8 months ago • 4 comments

Fix #857 Fix #874

skinkie avatar Apr 22 '25 08:04 skinkie

I cannot judge whether everything is really obsolete, so I don't dare approving.

Taking the example of LiftCallEquipmentRefStructure: I guess this is removed because element LiftCallEquipmentRef refers to the more general AccessEquipmentRefStructure. But wouldn't having it refer to LiftCallEquipmentRefStructure be the more proper solution?

PR #811 has been closed assuming that this PR #872 takes care of the changes in the examples. But this isn't the case, is it?

trurlurl avatar Apr 29 '25 12:04 trurlurl

I cannot judge whether everything is really obsolete, so I don't dare approving.

Taking the example of LiftCallEquipmentRefStructure: I guess this is removed because element LiftCallEquipmentRef refers to the more general AccessEquipmentRefStructure. But wouldn't having it refer to LiftCallEquipmentRefStructure be the more proper solution?

I would tocally agree. Those are actual valid bugs in the existing schema. Therefore we need people to actually validate why some structures are being removed.

PR #811 has been closed assuming that this PR #872 takes care of the changes in the examples. But this isn't the case, is it?

This is I think an unrelated comment. #811 is done in #876.

skinkie avatar Apr 29 '25 20:04 skinkie

@skinkie should @Aurige look at this first?

ue71603 avatar Jun 09 '25 16:06 ue71603

I guess start with the other assigned issues first, since this has merge conflicts now.

skinkie avatar Jun 09 '25 16:06 skinkie