NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

WIP: Updating Quay/StoPlace

Open JohanEntur opened this issue 8 months ago • 5 comments

Discussed in https://3.basecamp.com/3256016/buckets/2570434/messages/8335437909. I wanted this to be discussed first, but since we are running out of meetings, and this doesnt come up, I'll just post this right away.

Again, thanks to my colleague for composing the actual PR.

JohanEntur avatar Apr 07 '25 10:04 JohanEntur

Is QuayLayoutTypeEnumeration in use?

Can the different types have proper documentation?

skinkie avatar Apr 07 '25 11:04 skinkie

with proper documentation Stefan means:

			<xsd:enumeration value="lane">
					<xsd:annotation>
						<xsd:documentation>What does this really mean?</xsd:documentation>
					</xsd:annotation>
			</xsd:enumeration>

Also, always add such a thing to one of the appropriate example file (each element should be used at least in one example. Here e.g. one in https://github.com/NeTEx-CEN/NeTEx/tree/next/examples/functions/site

ue71603 avatar Apr 09 '25 17:04 ue71603

Otherwise looks good.

ue71603 avatar Apr 09 '25 17:04 ue71603

I initially thought that this would be for next release (not for v2), since it requires quite a lot of work:

  • articulation with existing enum: we will probably need to deprecate some values, and articulation between StopTypeEnumeration and StopPlaceCategoryEnumeration (may be chose a better name as pointed by @trurlurl ), also articulation between busStopWithinRoadwayBoarding or tramStopWithinRoadwayBoarding with the new QuayLayoutTypeEnumeration, etc.
  • for now the StopPlaceCategory is only in the StopPlaceView which is king of limited
  • it will also most probably require some discussion with the Transmodel group
  • etc.

So I would rather target it to a milestone after 2.0

Aurige avatar Apr 17 '25 17:04 Aurige

@Aurige ok for me either way. moved to 2.1 for the time being

ue71603 avatar Apr 19 '25 11:04 ue71603