NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

Make (Stop)PointInJourneyPatternRef for TimetabledPassingTime mandatory

Open skinkie opened this issue 9 months ago • 4 comments

Currently a TimetabledPassingTime without any reference to the ServiceJourneyPattern is considered valid by the XML Schema. Since it is a breaking change to fix it, now is the time.

skinkie avatar Mar 20 '25 00:03 skinkie

minOccurs=1

ue71603 avatar Apr 03 '25 14:04 ue71603

Just having the JourneyPatternRef (or view) mandatory in the ServiceJourney may be sufficient. And if we do it at TimetabledPassingTime level, we also need to do it at Call level.

Aurige avatar Apr 18 '25 13:04 Aurige

It is not sufficient. There is no relationshipship described anywhere between the specific TimetabledPassingTime and the JourneyPattern. Hinting that it may be in the same order will never work for situations with TimingPoints.

I obviously agree that at Call level the ScheduledStopPoint relationship also must be known.

skinkie avatar Apr 18 '25 13:04 skinkie

@Aurige Call should already have a mandatory ScheduledStopPointRef when #858 is fixed.

        <xsd:group name="StopPointInJourneyPatternViewPropertiesGroup">
                <xsd:annotation>
                        <xsd:documentation>Elements from a STOP POINT IN JOURNEY PATTERN VIEW.</xsd:documentation>
                </xsd:annotation>
                <xsd:sequence>
                        <xsd:element name="VisitNumber" type="xsd:positiveInteger" default="1" minOccurs="0">
                                <xsd:annotation>
                                        <xsd:documentation>Count of number of visits to this stop - as per SIRI use. Default is 1</xsd:documentation>
                                </xsd:annotation>
                        </xsd:element>
                        <xsd:choice>
                                <xsd:annotation>
                                        <xsd:documentation>Restrict just to SCHEDULED STOP POINTs.</xsd:documentation>
                                </xsd:annotation>
                                <xsd:element ref="ScheduledStopPointRef"/>
                                <xsd:element ref="ScheduledStopPointView" minOccurs="0"/>
                        </xsd:choice>

skinkie avatar Apr 21 '25 07:04 skinkie

Document update done in https://github.com/NeTEx-CEN/NeTEx/pull/859

Aurige avatar May 23 '25 15:05 Aurige