NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

ServiceJourney has JourneyPatternRef, shouldn't this be ServiceJourneyPatternRef?

Open skinkie opened this issue 1 year ago • 4 comments

The ServiceJourney allows the user to set the JourneyPatternRef. This allows the end user to use ServiceJourneyPatternRef, ServicePatternRef, DeadRunJourneyPatternRef and JourneyPatternRef.

Shouldn't we limit this to ServiceJourneyPatternRef?

This would break some things, especially if we change the element name too. And would certainly break the Nordic profile. But I honestly can't see why this type would be so wide.

skinkie avatar Feb 04 '24 10:02 skinkie

To be checked against Transmodel and propose an EPIP update if applicable (@Ulf9 @Aurige )

Aurige avatar Feb 22 '24 14:02 Aurige

This will indeed break the Nordic Profile and require rework for all producers/consumers. I think we should refrain from performing such breaking changes, unless there is a compelling reason to do so.

vpaturet avatar Feb 23 '24 09:02 vpaturet

This change would break the German Profile (VDV 462) as well. It would not be appreciated, as it would require much reworking of existing interfaces.

duexw avatar Sep 25 '24 13:09 duexw

No agreement for 2.0 but may be something to dive in for 3.0 ... with care for "old" systems. Shall we deprecate the ServiceJourneyPattern ? no agreement either ...

Aurige avatar Sep 25 '24 13:09 Aurige