NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

Remove External entities with for VDV compatibility in favor of Priva…

Open skinkie opened this issue 1 year ago • 10 comments

@duexw only if you like it.

skinkie avatar Dec 13 '23 14:12 skinkie

@ue71603 @trurlurl need example updates. Which require a quite complex update, being loading the externalStopRef and rewriting the deprecated PrivateCode.

skinkie avatar Dec 13 '23 14:12 skinkie

Fix #593

skinkie avatar Dec 13 '23 14:12 skinkie

I think we have to introduce PrivateCode in one or two places. or have should I model:

								<LineInDirectionRef>
									<ExternalDirectionRef type="uicType" ref="54"/>
									<!-- TapTsi B.4.7009 54 Talgo ! -->
									<!-- NB Work around to handle this case NeTEX needs to add additional filter -->
								</LineInDirectionRef>
								<ScheduledStopPointRef version="any" ref="uic:007300101"/>

And how to do this one?

						<Operator created="2003-06-09T14:20:00-05:00" changed="2004-05-09T14:20:00-05:00" modification="revise" version="1.0" id="noc:SCWW">
							<!-- NationalOperatorCode: PublicCOde -->
							<PublicCode>SCCW</PublicCode>
							<PrivateCode type="nocn">nocn:137725</PrivateCode>
							<ExternalOperatorRef type="vosa:LicenceNumber" ref="vosa:PD0000479"/>
							<!-- Name: TradingName  -->
							<Name>Stagecoach</Name>
							<ShortNa

ue71603 avatar Dec 13 '23 14:12 ue71603

@ue71603 I'll update all examples with #597 first.

skinkie avatar Dec 13 '23 15:12 skinkie

didn't we say deprecate, not remove ? removing will be an issue for @duexw and probably others ...

Aurige avatar Dec 13 '23 17:12 Aurige

@Aurige the point is most of these changes to next where never in master.

skinkie avatar Dec 13 '23 17:12 skinkie

For filters we need better examples.

skinkie avatar Jan 17 '24 16:01 skinkie

@skinkie we will have to do this together. Not clear to me, how we should fix the examples.

ue71603 avatar Jan 19 '24 11:01 ue71603

@Aurige @nick-knowles @skinkie @duexw does this still work for you?

ue71603 avatar Jan 24 '24 19:01 ue71603

Prefer DEPRECATION (for the ones in master only) and recommend the use of external codes Remove the ones only added in next...

Proposition to be updated

Aurige avatar Apr 16 '24 09:04 Aurige

Found in master (1.2.3):

  • ExternalOperatorRef
  • ExternalProductCategoryRef
  • ExternalLineRef
  • ExternalDirectionRef
  • ExternalStopPointRef
  • ExternalConnectionLinkRef
  • ExternalDatedVehicleJourneyRef
  • ExternalInterchangeRef
  • ExternalVehicleJourneyRef

Not in master:

=> all only depreciated

ue71603 avatar May 30 '24 14:05 ue71603

THis affects part1 documentation for some core framework elements. UML has been changed . Note also that PrivateCode should be moved from Generic utility types package to to Responsibility model types package UML image

image

image

image

nick-knowles avatar Jun 11 '24 13:06 nick-knowles