NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

StopPointInJourneyPatternRef must validate towards StopPointInJourneyPattern

Open skinkie opened this issue 2 years ago • 9 comments

I could argue that a proper validator would also validate that this StopPointInJourneyPattern is actually part of the same ServiceJourneyPatternRef. One may dream :-)

skinkie avatar Nov 29 '23 15:11 skinkie

I think I want to have some input. Should StopPointInJourneyPatternRef include an order attribute. The examples (and documentation does not have it) but the XML Schema suggests that it boils down to OrderedVersionOfObjectRefStructure which makes virtually every EPIP implementation wrong...

skinkie avatar Nov 29 '23 16:11 skinkie

The StopPointInJourneyPattern has a (possible) order as an attribute, so when you refer it with StopPointInJourneyPatternRef that implicitely includes that order

Aurige avatar Apr 16 '24 07:04 Aurige

The StopPointInJourneyPattern has a (possible) order as an attribute, so when you refer it with StopPointInJourneyPatternRef that implicitely includes that order

The point is that StopPointInJourneyPattern@id+version+order is unique. But one cannot refer to it via StopPointInJourneyPatternRef@ref+version because order is missing.

skinkie avatar Apr 16 '24 07:04 skinkie

But can a StopPointInJourneyPattern@id+version really have multiple orders (Transmodel does not seem to allow it) ? if not StopPointInJourneyPattern@id+version is enough for uniqueness

Aurige avatar Sep 04 '24 09:09 Aurige

StopPointInJourneyPattern has an order. Modelwise it does not make sense to make an exception. In my perspective it is either all validated to an order, or none. Notice all the UniqueBy_id_Version_Order within NeTEx_publication.xsd.

skinkie avatar Sep 04 '24 10:09 skinkie

Remove the order constraint from the reference. Add unique constraint so unique order is guaranteed without a ServiceJourneyPattern.

skinkie avatar Sep 04 '24 13:09 skinkie