NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

Should PassengerCarryingRequirementsView be a DataManagedObjectView/DerivedView?

Open skinkie opened this issue 2 years ago • 7 comments

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd#L668

skinkie avatar Jul 27 '23 13:07 skinkie

I think it would be good to have a cleaner hierarchy here.

ue71603 avatar Jul 29 '23 10:07 ue71603

To me, PassengerCarryingRequirementsView should have substitutionGroup="DerivedView" (the PassengerCarryingPassengerCarrying_ViewStructure has DerivedViewStructure as a base)

Aurige avatar Sep 07 '23 16:09 Aurige

@Aurige can you do this one?

ue71603 avatar Dec 12 '23 17:12 ue71603

I'm agnostic on this - perhaps calling a view a view is sufficient to identify it as a view, or should we formally make views substitutable subtypes of derived views? since views are all fof different things they dont really have common aspects other than a reference to the persistent element over which they provide a view

Another issue is concerns the ids of views. Doviews (a) always have an id?(b) is the id codespace the view's own unique id codespace , or is it the same as that of the source of a derived element ? (d) do we specify a constraint to enforce uniqueness?

It is probably useful to allow an id, so implentors who have actually implemented persistent entities corresponding to the view (e,g, CALLs ) , can make a round trip exchange.

nick-knowles avatar Dec 20 '23 17:12 nick-knowles

I'm agnostic on this - perhaps calling a view a view is sufficient to identify it as a view, or should we formally make views substitutable subtypes of derived views? since views are all fof different things they dont really have common aspects other than a reference to the persistent element over which they provide a view

If you would be willing to support such change, I would be happy to help. It would make things more clear once parsing them.

skinkie avatar Dec 20 '23 17:12 skinkie

@skinkie Can you formulate the PR then?

ue71603 avatar Feb 02 '24 11:02 ue71603