NeTEx icon indicating copy to clipboard operation
NeTEx copied to clipboard

fareStructureFactor vs fareStructureFactors?

Open skinkie opened this issue 1 year ago • 9 comments

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/NX.xsd#L139

skinkie avatar Jul 18 '23 13:07 skinkie

fareStructureFactors for sure

Aurige avatar Sep 07 '23 08:09 Aurige

fareStructureFactors for sure

Should it then also be fareStructures?

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/NX.xsd#L254

skinkie avatar Sep 07 '23 08:09 skinkie

Most probably, but only for consistency reasons ... this NX.xsd is just for information (not for use), so provided that you have either XXX either XXXs, the information is there, but consistency is always good !

Aurige avatar Sep 07 '23 08:09 Aurige

If it is actually documentation, it should not be in that folder for my perspective.

skinkie avatar Sep 07 '23 08:09 skinkie

Yes you are fully right

Aurige avatar Sep 07 '23 12:09 Aurige

@skinkie can we close this one?

ue71603 avatar Dec 12 '23 18:12 ue71603

@ue71603 if you add https://github.com/NeTEx-CEN/NeTEx/commit/258c905a6804cb73afd05c68907d8d7e30e6f59e

skinkie avatar Dec 12 '23 18:12 skinkie

@skinkie are those changes already committed? and in which PR? If so, can you close this issue?

ue71603 avatar Feb 02 '24 11:02 ue71603

Pls close, if done or add PR.

ue71603 avatar May 08 '24 10:05 ue71603

Only NeTEx_publication.xsd and NeTEx_siri.xsd are referenced in the documentation as possible entry point NX.xsd is never mentionned and is just provided for information (not for use, as explained in its header) => no need for doc update

Aurige avatar Oct 28 '24 14:10 Aurige