NuisanceFacilityEnumeration documentation update

[syversenkr]

See #132 (pull requested to 'master' branch, instead of 'next', due to discrepancies in current spec vs UML model vs implementation)

See NeTEx part - 1 7.7.14.4.2 Accommodation Facilities - NuisanceFacilityEnumeration:

"animalsAllowed" present in UML and now added to the XSD is missing in NuisanceFacilityType – AllowedValues "noAnimals" is present in UML and XSD, but not listed in NuisanceFacilityType – AllowedValues "breastfeedingFriendly" is present in XSD but missing in both UML and NuisanceFacilityType – AllowedValues And "other" is missing in the XSD, instead implemented as "unknown"

This should be corrected/consolidation.

In this case "other" makes more sense semantically (as not specified equals unknown), but if deprecating "unknown" this enumeration type is no longer backwards compatible.

Have therefore not added this enumeration to the XSD, would still recommend replacing "unknown" with "other".

If not, the UML and NuisanceFacilityType – AllowedValues must be updated to "unknown", or the type should contain both enumeration values.

[Aurige]

Since it's just a set of additional enum codes, it is Ok for me to go to master directly provided that we keep a document update action The only thing is taht I would add "other" (not replace "unknonwn" ... retrocompatibility..)

[ue71603]

Only the documentation updates needs to be done. Is already merged.

[nick-knowles]

UML is as follows

[trurlurl]

I still find discrepancies, or do I look at wrong places? The code, in master and next, does not list other yet. https://github.com/NeTEx-CEN/NeTEx/blob/next/xsd/netex_framework/netex_reusableComponents/netex_facility_support.xsd

And: the UML diagram doesn't list both items other and unknown as proposed by @Aurige

[ue71603]

@nick-knowles can you update the UML?

other addressed here: https://github.com/NeTEx-CEN/NeTEx/pull/724

[trurlurl]

Done, except for the UML diagram.