LOCUS icon indicating copy to clipboard operation
LOCUS copied to clipboard

move core_msgs and frontend_utils

Open yunzc opened this issue 2 years ago • 3 comments

Since PointCloudMapper depends on core_msgs and frontend_utils, I think it should be moved to the common pkg. Let me know what you guys think. See https://github.com/NeBula-Autonomy/common_nebula_slam/pull/1

yunzc avatar Sep 17 '22 15:09 yunzc

I am less up to speed on the different packages - so am happy for @femust to make the decision. I think we can eventually remove that package to be honest. Do you use it in LAMP at all @yunzc ?

BenjaminMorrell avatar Sep 27 '22 14:09 BenjaminMorrell

Yeah @BenjaminMorrell PointCloudMapper is also used in LAMP. So right now LOCUS is needed to compile LAMP, which is why I would like to move it to common_nebula_slam

yunzc avatar Sep 27 '22 14:09 yunzc

Ah, we should definitely move it to common then.

BenjaminMorrell avatar Sep 27 '22 15:09 BenjaminMorrell

ok let's merge this guys :)

femust avatar Oct 23 '22 17:10 femust