MapsetVerifier Some skin files are not recognized (e.g. mania combobursts)

Some skin files are not recognized (e.g. mania combobursts)

Open Asphyre opened this issue 4 years ago • 6 comments

Mapset Verifier doesnt seem to treat skin files as used ones since the file still shows up as unused in MV

Aug 17 '20 11:08 Asphyre

Which skin file is this in specific, and is there a mapset with this issue I can look at? Most of them should be detected if they're actually used.

Aug 17 '20 14:08 Naxesss

https://osu.ppy.sh/beatmapsets/1169658 comboburst files

https://osu.ppy.sh/community/forums/topics/1126031

Aug 19 '20 11:08 Asphyre

while you are at it, fix it for mania too

problem map: https://osu.ppy.sh/beatmapsets/1245882#mania/2589780

error screenshot https://i.imgur.com/nQ64sjm.png

skin wiki https://osu.ppy.sh/help/wiki/Skinning/osu!mania#comboburst

Sep 09 '20 20:09 dudehacker

have fixed both, also added support for other taiko/catch/mania skin elements

Sep 10 '20 08:09 Naxesss

its still showing error for "comboburst-mania-0.png" on latest version of 1.8.2

map with issue: https://osu.ppy.sh/beatmapsets/1226426#mania/2550329 screenshot

May 11 '22 23:05 dudehacker

different issue related to combo burst https://osu.ppy.sh/wiki/en/Skinning/osu%21mania

combo burst is Max height: 768px

but i tried using higher resolution image, its not flagged as problem

May 25 '22 23:05 dudehacker