CustomDiscs icon indicating copy to clipboard operation
CustomDiscs copied to clipboard

No sound from custom goat horns

Open Abbinabb opened this issue 11 months ago • 2 comments

It has a section for goat horns and player head but when we add a sound to the goat horns no matter the length or volume it's silent when it's played. It doesn't even play the regular sound.

Abbinabb avatar Jan 15 '25 06:01 Abbinabb

I removed those due to these types of changes being outside of what I know. In other words, I don't know of a way to proper implement these.

Navoei avatar Jan 16 '25 05:01 Navoei

Just a few extra details here :

  • Initial implementation (that I wasn't thinking to see it "merged" right away as this was a working but messy Proof of Concept more than anything else 😁 ) got removed in latest versions.

  • I'm still in the work of making it a reality, but Paper did lack of some API features (it's on the tracks with them, so that we should be able to implement a better way to handle Goat Horns in the future).

THERE IS NOT ETA as in when PaperMC teams and contributors will make it a reality, but I'm still trying to "push" them to advance on those changes 😅

There is still the definitions in the plugin to "change" the volume for players head or goat horns, but that will have no effects right now and I don't think it's a reason to change the code for this and publish a new release just for a cosmetic change (as this doesn't interfer with the rest of the plugins, so that's fine).

Athar42 avatar Jan 25 '25 19:01 Athar42