Nault icon indicating copy to clipboard operation
Nault copied to clipboard

Favicons

Open sebrock opened this issue 5 years ago • 5 comments

https://realfavicongenerator.net/ provides a service which creates a bundle of favicons to support for as many platforms/browsers as possible.

  • [x] Agree on Folder location for Banano favicons #98

  • [x] Upload favicon package to /src/themes/banano/assets/favicon

sebrock avatar Jul 28 '20 09:07 sebrock

@Nault/nano Are favicons created every time when building? (Asking because there is a folder src/assets/logo_source).

sebrock avatar Jul 28 '20 15:07 sebrock

Only two minor deficiencies identified by Favicon Checker with the Nault favicons currently image image

sebrock avatar Jul 28 '20 15:07 sebrock

@BitDesert I got the BananoNault favicons ready. Which path has to be used in site.webmanifest and browserconfig.xml ? Relative to src/themes/banano/assets/favicon/ ?

sebrock avatar Aug 11 '20 16:08 sebrock

If you want you can create a PR for them @sebrock If the filename stays the same you don't have to change anything there. The base path stays assets/*

BitDesert avatar Aug 11 '20 19:08 BitDesert

Favicons working fine on Chrome 84

image

sebrock avatar Aug 27 '20 09:08 sebrock