Nault icon indicating copy to clipboard operation
Nault copied to clipboard

Show correct rep label in account details even for unknown accounts

Open Joohansson opened this issue 5 years ago • 2 comments

It now says "unknown" because it only checks against rep list for local accounts and personal book. Nault should cache the ninja rep list and use it for lookups on any account.

image

Joohansson avatar Feb 19 '21 12:02 Joohansson

We can either cache all aliases and query locally ( https://mynano.ninja/api/accounts/aliases ) or query every address individually async: https://github.com/Nault/Nault/blob/master/src/app/services/ninja.service.ts#L66

Both is fine. Should start with local accounts --> address book --> ninja --> unknown

BitDesert avatar Feb 20 '21 13:02 BitDesert

i think the first option is better, especially for the tx list

for account summary (screenshot in the issue) you could also use the first option. unless you want to show voting weight % and donation button for reps not used by the currently configured wallet

keerifox avatar Feb 20 '21 18:02 keerifox