node-sylvester icon indicating copy to clipboard operation
node-sylvester copied to clipboard

Use of Global variables in $V, $L, $M, $P node package

Open jondayft opened this issue 9 years ago • 6 comments

Is there a reason that $V ,$L, $M, $P are in global scope? This is currently causing issues when testing with mocha, so we are having to add these to the mocha --globals option. Since everything is being exported it would seem like the attachment to global variable isn't required.

I assume there may be a very good reason for this but doesn't seem like best practice?

jondayft avatar Apr 20 '16 13:04 jondayft

+1

alexandrebodin avatar May 17 '16 14:05 alexandrebodin

+1

krazik avatar May 30 '16 18:05 krazik

+1

tommedema avatar Sep 08 '16 05:09 tommedema

+1

oveddan avatar Dec 06 '16 03:12 oveddan

Also: the global addition of Math.sign

connor4312 avatar Dec 30 '16 16:12 connor4312

Hi all, I recently signed on as a maintainer of this project. I'll slate this for a stable 1.0.0 release 😄

connor4312 avatar Jan 05 '17 04:01 connor4312