apparatus icon indicating copy to clipboard operation
apparatus copied to clipboard

Replace optional NPM dependency webworker-threads with web-worker

Open onlyurei opened this issue 3 years ago • 3 comments

Looks like webworker-threads is not maintained anymore, and the author recommends to use web-worker instead: https://github.com/audreyt/node-webworker-threads/issues/204 https://github.com/audreyt/node-webworker-threads/issues/206

onlyurei avatar Nov 06 '21 18:11 onlyurei

I don't see a dependency here on webworker-threads. I think you mean the dependency in NaturalNode, here: https://github.com/NaturalNode/natural/blob/master/lib/natural/classifiers/classifier_train_parallel.js Is that what you mean?

I can replace it with webworker.

Hugo-ter-Doest avatar Nov 07 '21 10:11 Hugo-ter-Doest

I don't see a dependency here on webworker-threads. I think you mean the dependency in NaturalNode, here: https://github.com/NaturalNode/natural/blob/master/lib/natural/classifiers/classifier_train_parallel.js Is that what you mean?

I can replace it with webworker.

@Hugo-ter-Doest Yes, sorry I opened the issue in the wrong repo - was trying to understand the e2e flow of NB classification class.

onlyurei avatar Nov 07 '21 19:11 onlyurei

I will ook into this.

Hugo-ter-Doest avatar Nov 07 '21 20:11 Hugo-ter-Doest