imglab icon indicating copy to clipboard operation
imglab copied to clipboard

Published 20 hours ago • verified publisher icon NaturalIntelligence

Dockerized version

Open francozacco opened this issue 5 years ago • 3 comments

Purpose / Goal

Added docker files to run the server on a docker container. I also added documentation explaining how to run the docker container.

Type

Please mention the type of PR

  • [ ] Bug Fix
  • [ ] Refactoring / Technology upgrade
  • [x] New Feature
  • [ ] Documentation
  • [ ] Other : | Please Specify |

francozacco avatar Jun 11 '20 20:06 francozacco

Thanks for your effort. But I'm wondering if the end-user is not aware of git. If he is using docker then probably docker pull imglab would be better option.

amitguptagwl avatar Jun 12 '20 00:06 amitguptagwl

Hi Amit, Yeap, It would be a problem if the end-user is not aware of git. I also uploaded a docker image to my account in docker-hub, you can find it here (https://hub.docker.com/r/francozacco/imglab) and I modified the documentation to account for these changes. But now I don't have the time to follow the steps to request an official image uploaded to docker-hub, I'm sorry 🙁. Let me know what you think.

francozacco avatar Jun 12 '20 02:06 francozacco

I appreciate your work. But we can't link any 3rd party code right now due to security reasons. But I'll think about it. However, now I'm thinking about its need. Currently, people just need to open it in their browsers once and it perfectly works offline. So no load on their system and no technical knowledge is required.

I feel we should focus more on the required features than good to have.

amitguptagwl avatar Jun 14 '20 14:06 amitguptagwl