vscode-sftp icon indicating copy to clipboard operation
vscode-sftp copied to clipboard

Save changes in `ipynb` are not recognized

Open kklot opened this issue 2 years ago • 5 comments

Do you read the FAQ?

  • [x ] Yes.

Describe the bug

Other files (markdown, R, python) synced fine when saving with some changes. The .ipynb in the same directory does not.

To Reproduce

Steps to reproduce the behavior:

  1. Create new python notebook and a python file.
  2. Set up SFTP config
  3. write something in each file and save

Expected behavior

Changes in ipynb is detected.

Desktop (please complete the following information):

VSCode Version: Version: 1.71.2
Commit: 74b1f979648cc44d385a2286793c226e611f59e7
Date: 2022-09-14T21:05:37.721Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 22.1.0
Sandboxed: No

kklot avatar Sep 19 '22 13:09 kklot

it is likely that the author should add the api: onDidSaveNotebookDocument to detect the save event of an notebook like .ipynb

Feliks151450 avatar Jan 07 '23 12:01 Feliks151450

any changes?

kizimenko avatar Jun 21 '23 14:06 kizimenko

@Natizyskunk I'm gonna take a look at it, it effectively seem that we need to implement the onDidSaveNotebookDocument api.

Natizyskunk avatar Jun 22 '23 19:06 Natizyskunk

I have the same problem. Save ipynb files cannot be uploaded .

Malibu351 avatar Aug 03 '23 06:08 Malibu351

Same problem. Would love a solution since python is one of the biggest drivers of remote dev servers

sudowoodo200 avatar May 23 '24 06:05 sudowoodo200