plugins icon indicating copy to clipboard operation
plugins copied to clipboard

feat: pdf-view

Open grigala opened this issue 2 years ago • 5 comments

Ported from: https://github.com/madmas/nativescript-pdf-view

@madmas could you follow up and maybe do a review?

  • [ ] Angular demo is missing so far.

grigala avatar Jul 27 '22 20:07 grigala

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @grigala. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar Jul 27 '22 20:07 cla-bot[bot]

@cla-bot check

grigala avatar Jul 27 '22 21:07 grigala

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jul 27 '22 21:07 cla-bot[bot]

@grigala this is great! thank you for kicking this off.

NathanWalker avatar Jul 28 '22 14:07 NathanWalker

We will likely rename this to just pdf as we will likely in the future work in other pdf features into this, for example also allowing PDFKit usage on iOS (and similar on android): https://stackblitz.com/edit/nativescript-pdfview-via-ios-pdfkit?file=src%2Fapp%2Fnative-pdfview%2Fnative-pdfview.ts

NathanWalker avatar Jul 28 '22 15:07 NathanWalker

@NathanWalker we completed the work on this from our perspective :) Demos are there and running for both Angular and Plain for iOS and Android

madmas avatar Aug 31 '22 19:08 madmas

This is amazing everyone. We’ll try to publish this before end of week.

NathanWalker avatar Sep 01 '22 05:09 NathanWalker

@nativescript/[email protected] published now. 🤗

We will likely add more features to this over time as mentioned, like including ability to create pdf's as well as convenience to go beyond just a viewer.

NathanWalker avatar Sep 01 '22 18:09 NathanWalker