nativescript-geolocation icon indicating copy to clipboard operation
nativescript-geolocation copied to clipboard

watchLocation errorCallback not being used

Open Vallhay opened this issue 6 years ago • 1 comments

In geolocation.js, line 150 the value of the watchLocation error callback is assigned to a var but then is never used. Im not sure if the watchLocation errorCallback is being call

Vallhay avatar Feb 01 '19 15:02 Vallhay

Hi @Faguaz, thanks for reporting! Indeed, in Android, the errorCallback of the watchLocation() method seems to never be called (see this line). It would be best to research if errors in watching location in Android can occur and call this callback if such is caught. Otherwise, the declaration

const zonedErrorCallback = zonedCallback(errorCallback);

... can be removed. We love pull requests, so if you have any ideas regarding this, feel free to contribute (make sure you assign this issue to yourself in this case)

tbozhikov avatar Feb 07 '19 12:02 tbozhikov