nativescript-dev-webpack icon indicating copy to clipboard operation
nativescript-dev-webpack copied to clipboard

Webpack compilation doesn't stop on syntactic errors in js/vue apps

Open endarova opened this issue 5 years ago • 1 comments

Environment CLI: @next Plugin(s): nativescript-dev-webpack@next

Describe the bug webpack compilation doesn't stop on syntactic errors in js/vue apps

To Reproduce

  1. tns create js_app --js
  2. npm i nativescript-dev-webpack@next --save-dev --save-exact
  3. node_modules/.bin/update-ns-webpack --deps --configs
  4. tns run iOS
  5. In main-view-model.js make syntactic error (add additional " somewhere) Result: webpack doesn't stop on error the app is deployed and crashes

Expected behavior the build should stop on the error and app should not be deployed broken

Additional context Not reproducible with [email protected] It is reproducible with run android too

endarova avatar Oct 16 '19 08:10 endarova

Currently CLI handles only Module not found errors (wrong require/import) in js/vue applications. This is due to the fact that Module not found errors are handled by webpack itself during the compilation. The .js files inside js/vue applications are processed using raw-loader. It doesn't analyze the code, just copies the content of the file to bundle/vendor. However, using another loader (for example, eslint-loader) will resolve this problem as it'll analyze the code according the give options (.eslint file) and will report them to the webpack. That way, CLI will stop on syntax/semantic errors in js/vue apps.

Fatme avatar Oct 22 '19 06:10 Fatme