nativescript-background-http icon indicating copy to clipboard operation
nativescript-background-http copied to clipboard

fix(android-request): Set custom user-agent from headers on Android request

Open phdd opened this issue 4 years ago • 1 comments

PR Checklist

  • [x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
  • [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • [x] All existing tests are passing
  • [ ] Tests for the changes are included

What is the current behavior?

The User-Agent header field is ignored on Android.

What is the new behavior?

The method request.setCustomUserAgent gets invoked copying the value from its correspondending header field.

phdd avatar Jul 21 '20 09:07 phdd

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @phdd. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar Jul 21 '20 09:07 cla-bot[bot]