nativescript-app-sync icon indicating copy to clipboard operation
nativescript-app-sync copied to clipboard

fix for ns7 (new app structure)

Open weathered-fire-2600 opened this issue 4 years ago • 4 comments

Referes to https://github.com/NativeScript/nativescript-app-sync/issues/72

Please not that this is major update and not backward compatible with ns6 due to different app structure. Users building ns6 based apps should use v2.0.0 of this plugin.

Currently there is a fix pending for nativescript-hook and I used the feature branch from @NathanWalker

Also one must use the fixed appsync-cli version, see https://github.com/Puracy/nativescript-app-sync-sdk-cli (pull request pending). With this fix you can build and release ns7 based apps to appsync server.

weathered-fire-2600 avatar Jan 12 '21 08:01 weathered-fire-2600

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @weathered-fire-2600. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar Jan 12 '21 08:01 cla-bot[bot]

@cla-bot check

weathered-fire-2600 avatar Jan 12 '21 08:01 weathered-fire-2600

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jan 12 '21 08:01 cla-bot[bot]

@EddyVerbruggen can you please merge it? @weathered-fire-2600 thx!

wendt88 avatar Jan 27 '21 08:01 wendt88

Any chance this will get merged soon?

sivo1981 avatar Dec 11 '22 12:12 sivo1981

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @weathered-fire-2600. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] avatar Feb 17 '23 16:02 cla-bot[bot]