nativescript-angular icon indicating copy to clipboard operation
nativescript-angular copied to clipboard

Clear all outletKeys instead of only the first

Open karsie opened this issue 4 years ago • 1 comments

PR Checklist

  • [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
  • [x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • [x] You have signed the CLA.
  • [ ] All existing tests are passing: https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests
  • [ ] Tests for the changes are included.

What is the current behavior?

Only the first outletKey of the outlet is used to destroy past views.

What is the new behavior?

All outletKeys of the outlet is used to destroy past views.

Fixes #2303.

karsie avatar Nov 26 '20 14:11 karsie

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kars Blom. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Nov 26 '20 14:11 cla-bot[bot]