canvas icon indicating copy to clipboard operation
canvas copied to clipboard

XMLHttpRequest break NS default functionality

Open CatchABus opened this issue 2 years ago • 2 comments

NativeScript Core already contains a polyfill for XMLHttpRequest here: https://github.com/NativeScript/NativeScript/blob/main/packages/core/xhr/index.ts

Canvas-polyfill uses its own polyfill: https://github.com/NativeScript/canvas/blob/master/packages/canvas-polyfill/async/xhr/TNSXMLHttpRequest.ts

This breaks functionality for libraries that use default NS polyfill (e.g. axios).

CatchABus avatar Aug 12 '22 23:08 CatchABus

There are somethings I need to add back into core to ensure the 3rd party libs used with canvas remain functional , that’s the only reason it exists

triniwiz avatar Aug 12 '22 23:08 triniwiz

Time to to move the extra features into core

triniwiz avatar Aug 22 '24 11:08 triniwiz