angular icon indicating copy to clipboard operation
angular copied to clipboard

Published 20 hours ago • verified publisher icon NativeScript

feat: standalone components

Open herefishyfish opened this issue 1 year ago • 6 comments

PR Checklist

  • [x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
  • [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • [x] You have signed the CLA.
  • [x] All existing tests are passing: https://github.com/NativeScript/angular/blob/master/DevelopmentWorkflow.md#running-the-tests
  • [ ] Tests for the changes are included.

What is the current behavior?

What is the new behavior?

Implements standalone components.

herefishyfish avatar Oct 03 '23 14:10 herefishyfish

Great work @herefishyfish - I'm thinking we plan to release this with ng 17, what do you think? Since it may introduce a breaking change.

NathanWalker avatar Oct 10 '23 15:10 NathanWalker

I believe there are no breaking changes with this. I'm wondering if we can also improve the dialogs as well. I'll take a look into how the CDK dealt with it

edusperoni avatar Nov 08 '23 18:11 edusperoni

Dang it, didn't make v17. Would love to have this as soon as possible 🙏

kyjus25 avatar Nov 17 '23 22:11 kyjus25

It seems like the commits are now a bit messy, can you rebase it on main?

edusperoni avatar Nov 17 '23 22:11 edusperoni

Sorry about that, should be good now.

I'm unsure if we should be removing the NgIf's from the platform filters in favour of the new control flow syntax - maybe I'll raise that as another PR.

herefishyfish avatar Nov 18 '23 11:11 herefishyfish

@edusperoni @NathanWalker Bump on this one, excited for it!

kyjus25 avatar Nov 28 '23 18:11 kyjus25