android icon indicating copy to clipboard operation
android copied to clipboard

fix: correctly load ts_helpers.js in workers

Open farfromrefug opened this issue 2 years ago • 4 comments

I added tests for this, the submodule needs to be update after the merge in the submodule repo

farfromrefug avatar Dec 16 '23 20:12 farfromrefug

Wouldn't it be better to maybe just add the fields in the configuration objects instead?

edusperoni avatar Dec 16 '23 21:12 edusperoni

@edusperoni not sure what you mean. You know the runtime much better than me. If you think there is a better way go for it !

farfromrefug avatar Dec 16 '23 21:12 farfromrefug

I mean adding on those 2 classes: "DynamicConfiguration" and "StaticConfiguration".

I'll take a look later to see how to best refactor it then

edusperoni avatar Dec 16 '23 21:12 edusperoni

@farfromrefug there's a build running with this. Can you confirm again if this solves your issues completely and doesn't break anything on your apps? I've simplified it and added tests, so it should be fine.

edusperoni avatar Feb 26 '24 18:02 edusperoni

@edusperoni i can confirm this works

farfromrefug avatar Jun 20 '24 19:06 farfromrefug