electron-plugin icon indicating copy to clipboard operation
electron-plugin copied to clipboard
verified publisher icon NativePHP

Laravel Reverb

Open simonhamp opened this issue 1 year ago • 2 comments

As laravel-websockets has been archived in favour of Laravel Reverb, we should look to support Reverb instead.

Fixes https://github.com/NativePHP/laravel/issues/295

Checklist

  • [ ] Tested on Mac
  • [ ] Tested on Linux
  • [ ] Tested on Windows
  • [ ] Docs updated

simonhamp avatar May 14 '24 08:05 simonhamp

On Windows 11, it works well before the build, but after the build, the software does not load

mr-ghomi avatar May 14 '24 19:05 mr-ghomi

PHP binary need pcntl extension to use Reverb

JamesHemery avatar May 22 '24 10:05 JamesHemery

Thanks to this PR, there is now a cross-platform friendly approach that won't require websockets at all.

As Reverb uses pcntl under the hood, it will never see support on Windows, which leaves running a client-side websocket server in a weird state across NativePHP apps.

I'm in favour of ditching setting up a websocket server altogether here, as for the majority use-case, it's probably overkill.

So I'm going to close this PR and potentially spin up another that removes websockets altogether.

simonhamp avatar Sep 11 '24 13:09 simonhamp