Inplace assignment doesn't work in this specific case
Even with the "Use inplace assignment operators" option enabled:
0.01% of the time it works everytime
There is an open pull request somewhere that improves it, however I found that it still didn't always work, usually with indirect reads/writes.
I couldn't find a PR, but here is the issue with patch that you mentioned: https://github.com/NationalSecurityAgency/ghidra/issues/5601
Looks like the author has several more pending PRs that (hopefully) improve decompilation too: https://github.com/NationalSecurityAgency/ghidra/pulls?q=author%3Alukeserne
I couldn't find a PR, but here is the issue with patch that you mentioned: https://github.com/NationalSecurityAgency/ghidra/issues/5601
Looks like the author has several more pending PRs that (hopefully) improve decompilation too: https://github.com/NationalSecurityAgency/ghidra/pulls?q=author%3Alukeserne
Ah yes that is what I was referring to ty