ghidra icon indicating copy to clipboard operation
ghidra copied to clipboard

tricore: fix mul.u zext order

Open q3k opened this issue 1 year ago • 1 comments

The operands needs to be zero-extended before multiplication, otherwise any overflow past 32 bits gets lost (and per the spec, these are explicity 32*32->64 bit multiplications).

q3k avatar Dec 27 '23 03:12 q3k

This definitely needs to be fixed. Ideally, we would fix this everywhere, not just for mul.u. It's also present in madds.u and msubs.u. Can you update the PR to address those as well?

GhidorahRex avatar Jan 05 '24 15:01 GhidorahRex