ghidra icon indicating copy to clipboard operation
ghidra copied to clipboard

Cropped text field in Data Type Chooser Dialog

Open jroimartin opened this issue 2 years ago • 4 comments

Describe the bug The text field in the Data Type Chooser Dialog is cropped.

To Reproduce

  1. Open a binary in CodeBrowser
  2. Go to a function
  3. In the Decompile window, retype a variable
  4. The Data Type Chooser Dialog shows only part of the text field

Expected behavior The layout of the Data Type Chooser Dialog should be shown correctly.

Screenshots image

Attachments None.

Environment

  • OS: Debian GNU/Linux bullseye (stable)
  • Desktop Environment: Gnome 3.38.5 (wayland and Xorg)
  • Java Version: Java 11 OpenJDK
  • Ghidra Version: 10.1.5
  • Ghidra Origin: Official GitHub distro

Also,

  • OS: Debian GNU/Linux bullseye (stable)
  • Desktop Environment: Gnome 3.38.5 (wayland and Xorg)
  • Java Version: Java 17 OpenJDK
  • Ghidra Version: master branch (5593df495c44cddcfe1c28a666d5d250f04b248d)
  • Ghidra Origin: GitHub repo

Additional context I could not reproduce this issue in:

  • Windows 10 + Java 17 Temurin + Ghidra 10.1.5
  • Debian bullseye + KDE 5.20.5 + Java 11 OpenJDK + Ghidra 10.1.5

jroimartin avatar Sep 05 '22 09:09 jroimartin

The issue is also reproducible in Ubuntu 22.04 (default installation) with Java 11 OpenJDK and Ghidra 10.1.5.

jroimartin avatar Sep 05 '22 10:09 jroimartin

Similar to #1506 and likely fixed. I will test tomorrow to confirm.

ryanmkurtz avatar Sep 07 '22 05:09 ryanmkurtz

Yes, it looks similar, and I can confirm that the severity varies from dialog to dialog. Here you have some more examples to check that the fix works:

image

(The text field is slightly cut off at the bottom)

image

(Both the progress bar and the sand clock are cut off at the bottom)

Thanks!

jroimartin avatar Sep 07 '22 07:09 jroimartin

Similar to #1506 and likely fixed. I will test tomorrow to confirm.

I have confirmed this is not fixed in 10.2-DEV.

image

ryanmkurtz avatar Sep 07 '22 15:09 ryanmkurtz

Fixed by 20c3374b187102cb00cb08b34f6a486c0fb3b026

ryanmkurtz avatar Nov 06 '23 15:11 ryanmkurtz