datawave icon indicating copy to clipboard operation
datawave copied to clipboard

Published 20 hours ago • verified publisher icon NationalSecurityAgency

Remove universal set

Open mineralntl opened this issue 2 years ago • 12 comments

mineralntl avatar Jan 13 '23 16:01 mineralntl

Unit tests will fail until metadata-utils is updated

mineralntl avatar Jan 19 '23 21:01 mineralntl

metadata-utils has been tagged and updated, everything should be working now

mineralntl avatar Jan 20 '23 16:01 mineralntl

After reading the ticket, I wonder if this should be changed as part of it: https://github.com/NationalSecurityAgency/datawave/blob/integration/warehouse/query-core/src/main/java/datawave/core/iterators/filter/GlobalIndexDataTypeFilter.java#L42 Seems to violate the second rule unless there's something I'm missing.

hlgp avatar Jan 31 '23 02:01 hlgp

Hoping to take a look at this in depth this week.

jwomeara avatar Feb 07 '23 17:02 jwomeara

Good catch @hlgp - updated to match the rules outlined in the ticket

mineralntl avatar Feb 07 '23 17:02 mineralntl

Oh also, WiredQueryExecutorBeanTest failed for me when I built this. You can run this test as part of your build with -Ddeploy

jwomeara avatar Feb 18 '23 18:02 jwomeara

Changing to draft as various classes are updated in pieces

mineralntl avatar Mar 21 '23 19:03 mineralntl

Adding FieldMissingFromSchemaVisitor/Test as well - found during testing.

mineralntl avatar Mar 21 '23 21:03 mineralntl

These changes are tied to datawave-metadata-utils#20 as this branch is dependent on those changes for fully removing UniversalSet and handling empty but non-null datatype filters.

mineralntl avatar Mar 29 '23 14:03 mineralntl

Is this ready to be reviewed again?

jwomeara avatar Apr 22 '23 19:04 jwomeara

All comments addressed - should be good to go

mineralntl avatar Apr 25 '23 16:04 mineralntl

Somehow removed a bunch of changes during last attempt at fixing the merge conflicts - reverted and attempting again

mineralntl avatar Jun 22 '23 19:06 mineralntl