datawave icon indicating copy to clipboard operation
datawave copied to clipboard

Published 20 hours ago • verified publisher icon NationalSecurityAgency

Refactor LimitFields

Open apmoriarty opened this issue 3 years ago • 1 comments

Refactor the LimitFields class and add unit tests.

The work done to address https://github.com/NationalSecurityAgency/datawave/issues/1678 was a limited-scope bugfix, but surfaced some issues with readability and object creation.

  • variable names that are too long and don't make sense
  • method names that are too long and don't make sense
  • extra object creation inside deeply nested loops
  • accurate docs

apmoriarty avatar Aug 30 '22 16:08 apmoriarty

I think LimitFields has actually gotten worse since this was written...but a few performance bugs were ironed out in the process. So maybe call it a draw.

apmoriarty avatar Apr 23 '25 12:04 apmoriarty