datawave icon indicating copy to clipboard operation
datawave copied to clipboard

Fix node lineage in JexlNodeFactory.createNodeTreeFromFieldsToValues

Open apmoriarty opened this issue 3 years ago • 1 comments

This is a second cut of https://github.com/NationalSecurityAgency/datawave/pull/1273 after the changes to refactor the parallel index expansion.

Change summary

  • instead of building out nodes in-place, children are built first and the parent node is build last (simplifies logic)
  • more instances of copying a node (preserves node lineage)
  • added tests for JexlNodeFactory and UnfieldedIndexExpansionVisitor

apmoriarty avatar Dec 30 '21 12:12 apmoriarty

This looks consistent, but hard to tell if it's 100% correct.

FineAndDandy avatar Jan 18 '22 15:01 FineAndDandy