Rémy HUBSCHER

Results 380 comments of Rémy HUBSCHER
trafficstars

@rtwruck you can add multiple combinaison of valid BIC for the same bank code. [We did it in France for BNP which has a similar complexity.](https://github.com/mdomke/schwifty/blob/main/tests/test_bic.py#L160-L186) It will work for...

Yes it goes both ways, multiple bank codes can share the same BIC and multiple BIC can be linked to the same bank code

I don't like to start discussion like that when code is already written and I really would like this kind of implementation to start with an article that explain the...

I agree with you that it should not be mandatory to write an article prior to any change in the code base. I see writing an article more like a...

As far as I understood the idea was to mark listener as async or sync in the configuration and being able to select the async backend we'd like to use...

> Wait for #651 to be merged, and plug listeners to AfterResourceChanged Just async onces maybe. This should be configurable at the listener configuration level. > Add an async parameters...

This is related to this code: ``` # New logger context, with infos for request summary logger. logger.new(agent=request.headers.get('User-Agent'), path=event.request.path, method=request.method, querystring=dict(request.GET), uid=request.authenticated_userid, lang=request.headers.get('Accept-Language'), authn_type=getattr(request, 'authn_type', None), errno=None) ```

Apparently it is a bug in Pyramid. We can reproduce quite easily with every Cliquet related projects :(

And probably cornice and pyramid projects too...