StackMob-5 icon indicating copy to clipboard operation
StackMob-5 copied to clipboard

Prevent villagers with different professions from stacking

Open CW-UK opened this issue 4 years ago • 7 comments

I can't seem to stop villagers with different professions from stacking. Example:

  1. Spawn two villagers apart from each other (outside the merge radius)
  2. Give both a different workstation so that they gain professions
  3. Let the two villagers meet

Both villagers will merge into one, despite having two different professions. I've tried some config trait options such as:

profession: true villager-profession: true fletcher: true profession-fletcher: true

CW-UK avatar Jun 20 '20 21:06 CW-UK

Good idea, but villagers shouldn't be authorized to stack themselves, just add them to type_blacklist ^^

Aurelien30000 avatar Jun 20 '20 21:06 Aurelien30000

Forgive my ignorance for asking, but I'm going by the comment in the config file:

# Whether entity specific traits (e.g. profession, colour) should be segregated (*)

I'm aiming for villagers of different professions to stack, which seems to be suggested by this comment.

CW-UK avatar Jun 20 '20 21:06 CW-UK

Currently there is no option (trait) for villagers, maybe we could add one ? :p

Aurelien30000 avatar Jun 20 '20 22:06 Aurelien30000

I believe it's a valid addition, as villagers can stack up in their professions from spawners and be cycled through by killing them off. I know other networks that use StackMob that stack their villagers by profession, but they are using an older version, so maybe it's been removed in later versions? Or perhaps they modified the plugin.

In the mean time it may save people like from me from wasting their time if the config line is adjusted so that it doesn't indicate profession segregation is possible.

CW-UK avatar Jun 20 '20 22:06 CW-UK

@CW-UK I added villager-profession trait to this pull request's build (latest) -> https://github.com/Nathat23/StackMob-5/pull/101

WARNING : Contains others huge changes that could cause issues currently, be aware and don't hesitate to report issues ^^ Thanks!

Aurelien30000 avatar Jun 21 '20 10:06 Aurelien30000

I think I never added support for villager professions because there's no way to keep the trades that villagers may have.

ploppyperson avatar Jun 29 '20 15:06 ploppyperson

I think I never added support for villager professions because there's no way to keep the trades that villagers may have.

Exactly, but it doesn't costs anything to have it :)

Aurelien30000 avatar Sep 16 '20 16:09 Aurelien30000