StackMob-3 icon indicating copy to clipboard operation
StackMob-3 copied to clipboard

uk.antiperson.stackmob.tasks.TagTask causing severe lag.

Open andrewkm opened this issue 7 years ago • 10 comments

StackMob::Task: uk.antiperson.stackmob.tasks.TagTask (interval:5)count(1200) total(54.43% 202.015s, 215.25% of tick)avg(168.35ms per - 107.63ms/0.64 per tick)

https://i.imgur.com/RiRAKyU.png

Anyway we can improve performance in regards to the above task? We are currently running StackMobs built upon: https://github.com/Nathat23/StackMob-2/commit/236854678fb109a4f6a5880208115f0cade81b80

Please help. It's gotten quite bad lately with the latest code changes.

andrewkm avatar Jul 16 '18 16:07 andrewkm

Going to be changing:

# Everything related to the tag seen above entities
tag:
    # The delay between updates of the name tag.
    interval: 5

to

# Everything related to the tag seen above entities
tag:
    # The delay between updates of the name tag.
    interval: 100

Perhaps this will help? If you can look into this would be great.

andrewkm avatar Jul 16 '18 16:07 andrewkm

The latest commits have switched the replace functions to apache-commons, so there may be some improved performance.

ploppyperson avatar Jul 22 '18 21:07 ploppyperson

Awesome :) Thanks! Will continue to monitor this.

andrewkm avatar Jul 23 '18 16:07 andrewkm

Oh wait, can't really test this as it probably won't work on 1.12.2 anymore due to your 1.13 changes @Nathat23.

Can you possibly add the performance / other stuff to your 1.12.2 legacy branch?

andrewkm avatar Jul 23 '18 16:07 andrewkm

Any update on this? Getting severe lag from this.

matthewmarion avatar Aug 12 '18 17:08 matthewmarion

Can’t really test unless @nathat23 made a legacy branch for 1.12.2 with the fix :(

andrewkm avatar Aug 12 '18 19:08 andrewkm

Disabling 'tag.show-player-nearby.enabled' should improve performance.

ploppyperson avatar Aug 21 '18 11:08 ploppyperson

Thanks @Nathat23 I've disabled show-player-nearby for now and am monitoring performance. @matthewmarion let us know if disabling that option helps your problems as well :)

andrewkm avatar Aug 29 '18 10:08 andrewkm

3.0 has even more performance increases.

ploppyperson avatar Nov 03 '18 20:11 ploppyperson

Sadly am stuck on legacy version due to ASkyBlock not getting an update.

andrewkm avatar Nov 03 '18 23:11 andrewkm