angular-seed-advanced
angular-seed-advanced copied to clipboard
TEMP_FILES ignoring JS breaks APP_ASSETS js injections
I'm submitting a ... (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)
Current behavior If you create a libs (or any other folder to store your local js) inside src/ then try to include that file for injection in project.config APP_ASSETS as the comments state the JS is ignored and never injected. However if you provide the complete root path it works.
Expected behavior When adding a JS file that you want to be injected it should not be ignored, and should be added to the page.
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
This: https://github.com/NathanWalker/angular-seed-advanced/blob/master/tools/config/seed.config.ts#L396
Is breaking this: https://github.com/NathanWalker/angular-seed-advanced/blob/master/tools/config/project.config.ts#L29
Commenting out the line in seed.config.ts enables the injection to work as stated in the comments. Another related issue with this type of ignoring files is https://github.com/NathanWalker/angular-seed-advanced/blob/master/.vscode/settings.json#L5
Should be this instead to show JS files that you write that are not in TypeScript.
"src/client/**/*.js": {"when": "$(basename).ts"},
Please tell us about your environment:
MacOS, Visual Code
-
Angular Seed Version:
6e7a949
-
Node:
node --version
= v7.7.4