ascii_qgis
ascii_qgis copied to clipboard
Mainly formatting tidy ups to the main module
- wrap to 80 cols
- removed unused imports
- pythonic naming convention (e.g. underscore separated names)
- don't shadow globals / outer scopes in inner scope vars
- fix spacing
- generally make it fit my a-type brain better :-P
I should mention it still doesn't run right (no rendering) for me on OSX - working on that still. You may want to test my changes locally before merging to be sure I never broke something on linux / win.
Thanks. I'm doing a bit of a rework so you might get conflicts
On Thu, 10 Mar 2016 7:50 am Tim Sutton [email protected] wrote:
I should mention it still doesn't run right (no rendering) for me on OSX - working on that still. You may want to test my changes locally before merging to be sure I never broke something on linux / win.
— Reply to this email directly or view it on GitHub https://github.com/NathanW2/ascii_qgis/pull/5#issuecomment-194524806.
Will test once I'm done
On Thu, 10 Mar 2016 7:54 am Nathan Woodrow [email protected] wrote:
Thanks. I'm doing a bit of a rework so you might get conflicts
On Thu, 10 Mar 2016 7:50 am Tim Sutton [email protected] wrote:
I should mention it still doesn't run right (no rendering) for me on OSX
- working on that still. You may want to test my changes locally before merging to be sure I never broke something on linux / win.
— Reply to this email directly or view it on GitHub https://github.com/NathanW2/ascii_qgis/pull/5#issuecomment-194524806.
@timlinux for the no rendering. You might just have to put a bunch of logging at char setting and colour setting, etc
I will test on the OSX install when I get some time.
Thanks. I'm doing a bit of a rework so you might get conflicts
No problem - I will fix them as they happen