Nathan Rebours

Results 151 comments of Nathan Rebours

We're working on improving the parts of the code interacting with the github API so hopefully it should fix these kind of issues.

It seems like there's a demand for such functions so I suggest you open a PR with what you have so far and we can discuss the details there. Is...

I'll add the successful ones to the current test suite and the rest of the test cases to a separate one. Then we can start fixing the ones worth fixing...

Yeah I just ran the test suite I added right now with `Yojson.Safe` and the remaining failures are: - `n_structure_object_with_comment.json` - `n_structure_angle_bracket_null.json` - `n_string_unescaped_tab.json` - `n_string_unescaped_newline.json` - `n_string_unescaped_crtl_char.json` - `n_object_unquoted_key.json`...

It seems like it's a slightly different set of failures but the test suite now covers the more up-to-date RFC 8259 which explains some differences.

I totally agree there is a use case for this, in particular we considered adding support for this through a ppxlib callback provided to one's expand function when we considered...

Let me know if you want me to provide a minimal example.

I tend to find it a little unsettling when errors for generated code are located on code that I wrote myself, especially when the error is highlighted by merlin in...

> when errors for generated code are located on code that I wrote myself Let me clarify that a bit since it will inevitably be located on code that I...