Nathan Xu

Results 33 comments of Nathan Xu

Thsnks for the bug reporting and the PR. Seems a good catch and fixing. The only thing that is missing is a testing case which shows: 1. without the code...

> Thank you for taking a look in this PR :) > > I'll check existing tests, it might be specially hard to create one for this issue, specially because...

@yrodiere feel free to take a look at this ticket for the reporter claimed it is a regression issue introduced by https://hibernate.atlassian.net/browse/HHH-13266. Seems complicated for it seems your PR was...

> @NathanQingyangXu Thanks, but I don't really have the time right now. I'll have a look in a few weeks if nobody else does. If my Anyway, if my PR...

Usually PR is targeting `master` branch rather than some specific version branch, so when it is merged to master, core team member can determine whether to back port to 5.4...

@Sanne @dreab8 It seems there is some good stuff here. Could you take a look when you have time?

> > Usually PR is targeting `master` branch rather than some specific version branch, so when it is merged to master, core team member can determine whether to back port...

As a matter of fact, I am a community contributor and recently I am busy with my own job with little free cycles left. On Mon., Feb. 8, 2021, 16:26...

> Do we need to do anything special here with copyrights and/or licenses? I have no idea in this respect. @beikov , @dreab8 @Sanne how do you think?

Nope, I created these classes purely based on the open documentations. On Tue., Apr. 26, 2022, 6:57 a.m. Sanne Grinovero, ***@***.***> wrote: > @NathanQingyangXu how did you > create these...