Nate Radebaugh

Results 27 comments of Nate Radebaugh

I know there is a `useUnknownInCatchVariables` in `tsconfig.json` but it doesn't seem to work for promises. There's a similar request in the TypeScript codebase, but that feature request hasn't gotten...

Looks like this will be solved by #112

You can write a small function to have a promise that only resolves once the dialog is closed: ```ts export async function showModalDialogWithRef(dialogService, content, data) { const dialogRef = dialogService.open(content,...

Interesting. Try passing the callback as part of the `data` object then, and you can call it from your modal directly.

Thanks so much for this! In testing this, I noticed a couple other missing features from the vscode extension: * Showing the actual lint error name in the UI instead...

> > Thanks so much for this! In testing this, I noticed a couple other missing features from the vscode extension: > > > > * Showing the actual lint...

Not sure if there's an RFC for this but is there a performance impact to recomputing the value each time? Is there some automatic marshaling as signal that could memo-ize...