Skosmos icon indicating copy to clipboard operation
Skosmos copied to clipboard

Use getConceptURL function when forming links to concepts

Open joelit opened this issue 4 weeks ago • 0 comments

Description of the enhancement

Searhch components form concept links ad hoc. Instead, this nifty global function should be tested and used.

Who are the users that would benefit from the enhancement and how?

The code would be cleaner that way.

What new functionalities would the enhancement make possible?

Currently, the getConceptURL does not really work in all possible use cases, e.g. when forming a search result concept link in global search context, it would give us a link like this: http://localhost/fi/page/?uri=http%3A%2F%2Fwww.yso.fi%2Fonto%2Fyso%2Fp19378&clang=

Desired result would be more like this: http://localhost/your-skosmos-installation-folder/fi/page/?uri=http%3A%2F%2Fwww.yso.fi%2Fonto%2Fyso%2Fp19378

Since the content language parameter is not handled correctly, it's possible that url parameters need to be tested case-by-case, with better parameter handling and cypress tests added.

Possible use cases for this function:

  • vocabulary search autocomplete dropdown list
  • global search autocomplete dropdown list
  • vocabulary search result page
  • global search result page

Why is the enhancement important?

Conan! What's best in life?

  • To crush all bugs
  • See them tested in cypress before you push
  • And hear the sweet song of good infrastructure

joelit avatar Dec 05 '25 09:12 joelit