Skosmos icon indicating copy to clipboard operation
Skosmos copied to clipboard

Upgrade to EasyRdf 1.14.0

Open osma opened this issue 1 year ago • 1 comments

Reasons for creating this PR

We should use recent versions of EasyRdf (see #1700). This PR upgrades EasyRdf from 1.13.1 to 1.14.0, fixing some mock resources in the test suite according to changes in that release.

This isn't the latest version of EasyRdf, but the next release 1.14.1 changes some Accept headers used in SPARQL CONSTRUCT queries. It appears that those changes are not compatible with the (rather old) Jena 4.8.0 version of Fuseki we are using, so going any further probably requires upgrading Fuseki as well. The most recent EasyRdf release currently is 1.15.0.

Link to relevant issue(s), if any

  • Closes #1700 (maybe)

Description of the changes in this PR

  • bump the EasyRdf dependency to 1.14.0
  • fix some mocked resources in tests

Known problems or uncertainties in this PR

Is this enough for now, or should we aim for 1.14.1 or 1.15.0 (the current newest release)?

Checklist

  • [x] phpUnit tests pass locally with my changes
  • [x] I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • [x] The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • [x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

osma avatar Dec 18 '24 15:12 osma

Rebased on current main and force-pushed. Let's see if we can push this further instead of stopping at 1.14.0. We now have a newer Fuseki thanks to #1775 / PR #1778 (Fuseki 5.3.0) and PR #1788 (Fuseki 5.4.0).

osma avatar Oct 28 '25 08:10 osma

Nope, the tests are still failing for EasyRdf 1.14.1 and above (also tested newest EasyRdf release 1.17.0). It seems there is still a compatibility issue between EasyRdf 1.14.1+ and Fuseki. This should probably be investigated further and reported to EasyRdf.

osma avatar Oct 28 '25 08:10 osma

The Fuseki compatibility issues have been sorted out in EasyRdf 1.18.0, so I bumped to that version. Also rebased on current main and force-pushed.

Sadly, there is another EasyRdf/Fuseki compatibility issue; the Turtle parser fails to parse empty CONSTRUCT query responses. Reported as https://github.com/sweetrdf/easyrdf/issues/74

osma avatar Nov 24 '25 14:11 osma

There was one more EasyRdf bug, in the RDF/XML parser. It is now fixed and 1.18.2 has been released with the fix. This PR uses 1.18.2+ and everything seems to be working now.

osma avatar Nov 26 '25 14:11 osma