Skosmos icon indicating copy to clipboard operation
Skosmos copied to clipboard

Sorting by notation does not work in groups tab if showNotation is false

Open kouralex opened this issue 3 years ago • 2 comments

At which URL did you encounter the problem?

At my local installation using a vocabulary with notated groups.

What steps will reproduce the problem?

  1. Set skosmos:showNotation "false"; skosmos:sortByNotation "true"; for the locally installed vocabulary in question (similarly to https://finto.fi/yso-aika/fi/ where these configuration settings are applied and working)
  2. Observe the Groups tab

What is the expected output? What do you see instead?

I expect to see the values ordered by notation codes. For YSO-aika, this is working in the Hierarchy tab. Looking at the code, it seems like sorting is done differently: https://github.com/NatLibFi/Skosmos/blob/0a51dd58bae105fa4c27ea0c1955a908489180e2/resource/js/groups.js#L55 https://github.com/NatLibFi/Skosmos/blob/0a51dd58bae105fa4c27ea0c1955a908489180e2/resource/js/hierarchy.js#L503-L532

I would assume that refactoring so that both codes use the same approach would yield identical behavior between the tabs in question.

kouralex avatar Nov 24 '22 22:11 kouralex

I'd like to understand this situation a bit better -- which vocabularies would this affect, and why is this enhancement important? We could prioritize our work better once these are clear. :)

joelit avatar Feb 09 '23 08:02 joelit

The vocabulary in question is Metatietosanasto (https://finto.fi/mts/fi/) for which I am the technical maintainer. Metatietosanasto has its hierarchy based on groups. The problem arises from the fact that users would like to have (some) groups in groups tab to be sorted in a fixed way but this is not possible at the moment due to the issue described above. See, e.g., http://urn.fi/URN:NBN:fi:au:mts:m4979 where a more appropriate ordering would be non-alphabetical "Teos, Ekspressio, Manifestaatio, Kappale, Toimija, Suhteet, Ajanjakso, Paikka" listing in Finnish and likewise in Swedish (i.e., one must have a language-agnostic way to set the ordering of identifiers - hence the skos:notation approach could work).

In case you are wondering on what else to prioritize I would heavily suggest #810/#620 to be tackled ASAP as solving that would allow Metatietosanasto (and propably other vocabularies, too) to prosper big time.

kouralex avatar Feb 09 '23 11:02 kouralex