NatLibFi
Fix plugins that were broken in the Bootstrap upgrade
At which URL did you encounter the problem?
https://dev.finto.fi/finaf/fi/page/000000515 https://dev.finto.fi/yso/fi/page/p18776 .. and likely in many other URLs related to the vocabularies maintained with Skosmos using the latest master branch and including the Bootstrap 5 updates.
Which steps will reproduce the problem?
- In your own local Skosmos installation, configure and take into use at least the following plugins:
- Finna
- Map
- Message
- Finaf
- Wikipedia (it may be needed to go through other plugins as well)
- Make sure that you have pulled the latest master branch.
- Run: php composer.phar self-update
- Run: php composer.phar update
- Create a new branch for the testing.
- Visually inspect the appearance and functionalities of the plugins to find possible issues.
- Check the next PR including the Bootstrap upgrades: https://github.com/NatLibFi/Skosmos/pull/1182
Help for the steps 3-4: https://github.com/NatLibFi/Skosmos/wiki/Upgrading
What is the expected output? What do you see instead?
Correctly working plugins / Broken layouts
What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)
Firefox
This is what we have now (co-operation with @Vainonen & @miguelvaara): https://github.com/NatLibFi/skosmos-widget-finaf/compare/bootstrap-update
It is not much but a beginning. After working together @miguelvaara tried to setup Finaf (Kanto) vocabulary in his own development environment. Maybe the most mysterious 🤔 part is that everything seems to be fine on the code side and in the DOM but the Finaf widget remains hidden.
Maybe @Vainonen provides some tips later on .. 🙂
Next in line: Finna widget https://github.com/NatLibFi/Skosmos-widget-finna/issues/11
This is what we have now (co-operation with @Vainonen & @miguelvaara): https://github.com/NatLibFi/skosmos-widget-finaf/compare/bootstrap-update
Applied that diff locally, after copying the finaf vocab settings, and accessing finto.fi to compare with my local installation.
Here's the current broken plugin page:
Here's after applying the diff.
Here's Finto:
It is not much but a beginning. After working together @miguelvaara tried to setup Finaf (Kanto) vocabulary in his own development environment. Maybe the most mysterious thinking part is that everything seems to be fine on the code side and in the DOM but the Finaf widget remains hidden.
In case it helps, here's what I did @miguelvaara :
- Cloned the plugin to
skosmos-clone/plugins/finaf - After installing Finaf as in Finto, I made sure I had
skosmos:usePlugin "finaf" ; - Opened a URL from Finto, e.g. https://finto.fi/finaf/en/page/000001172?clang=fi, locally to compare the results http://localhost:9090/finaf/en/page/000001172?clang=fi (with Docker Compose)
I think the diff is fixing most of the Bootstrap mayhem, except for the icons. @osma, I think we had a similar issue in the Bootstrap issue, where I used a SVG since Bootstrap removed its icons.
If needed, we can open a new issue to add back the icons via an alternative dependency (Bootstrap website should list a few alternatives). This way the finaf plug-in can also be updated to show the icons correctly.
Other than that, looks good to me! Great job @Vainonen & @miguelvaara :bow:
I added pull requests to Skosmos-widget-map and Skosmos-wdget-wiki with their respective fixes for Bootstrap 5
@osma, @MikkoAleksanteri, the Finna-widget needs a review and comments:
PR: https://github.com/NatLibFi/Skosmos-widget-finna/pull/12
Example: https://dev.finto.fi/yso/fi/page/p24974
I think we are done (for now) with this? Anyway, the issues should be handled in the repos of individual widgets rather than this Skosmos repo, which is really about the Skosmos codebase and not the widgets.
