Skosmos icon indicating copy to clipboard operation
Skosmos copied to clipboard
verified publisher icon NatLibFi

Refactoring 2022 03 31

Open miguelvaara opened this issue 3 years ago • 1 comments

Reasons for creating this PR

Property values in the Skosmos or vocabulary configuration, got by a key should not be called directly, therefore the properties need separate interfaces (methods). This makes it easier to debug the code and the structure of the code will be easier to read, understand and maintain.

Link to relevant issue(s), if any

  • Closes #

Description of the changes in this PR

Refactored those parts of the code in the VocabularyConfig.php where properties were called without dedicated methods. Added methods for the properties without an API.

Tests are needed but they will be made after the first review, after the implementation and the quality of the code have been checked.

Tests are needed but they will be made after the first review, after the idea and the quality of the code is checked.

Known problems or uncertainties in this PR

Checklist

  • [ ] phpUnit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • [ ] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

miguelvaara avatar Apr 22 '22 08:04 miguelvaara

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 22 '22 08:04 sonarqubecloud[bot]