Skosmos icon indicating copy to clipboard operation
Skosmos copied to clipboard

The vocabulary list on the frontpage shows the vocabulary names in th…

Open miguelvaara opened this issue 4 years ago • 3 comments

…e default language of the vocabulary

Thanks @henriyli, @osma and @kouralex for your contribution :-)

Reasons for creating this PR

To follow wishes mentioned in the PR #747

Link to relevant issue(s), if any

#731

  • Closes #

Description of the changes in this PR

The vocabulary list on the front page shows the vocabulary names in the default language of the vocabulary

Known problems or uncertainties in this PR

Checklist

  1. For the vocabulary of your choice, point out the default language in the config.ttl (make sure the dc:title is also defined with respect to the default language)
  2. In Skosmos, select the content language not used in the vocabulary
  3. On the Skosmos front page check if the vocabulary name in the list is shown in the default language

When it comes to the phpUnit tests, at the moment I am investigating ways to run PHPUnit tests for Symphony Twig templates. Tests are coming a bit later.

  • [ ] phpUnit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • [ ] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

miguelvaara avatar Dec 22 '21 17:12 miguelvaara

Codecov Report

Merging #1259 (7d99329) into master (a770d4c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1259   +/-   ##
=========================================
  Coverage     69.26%   69.26%           
  Complexity     1646     1646           
=========================================
  Files            32       32           
  Lines          4041     4041           
=========================================
  Hits           2799     2799           
  Misses         1242     1242           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a770d4c...7d99329. Read the comment docs.

codecov[bot] avatar Dec 22 '21 17:12 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 23 '21 12:12 sonarqubecloud[bot]

Another question is where the business logic is located. For instance, I think it is also possible to modify a request according to the needs mentioned in the original issue. The configuration and therefore the default language of the vocabulary could be checked before accessing the data depending on the request.

miguelvaara avatar Jan 19 '22 18:01 miguelvaara