Skosmos icon indicating copy to clipboard operation
Skosmos copied to clipboard

Remove the dependency to deprecated gettext-extractor package

Open joelit opened this issue 3 years ago • 3 comments

Reasons for creating this PR

This PR removes the dependency to twig-gettextExtractor, as it is a package no longer maintained

Link to relevant issue(s), if any

  • Closes #1153

Known problems or uncertainties in this PR

This PR will not get rid of related and abandoned twig-extensions package, as it is used by the twig translation filters in Skosmos. There is a separate issue of that in #1247

Checklist

  • [x] phpUnit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • [x] The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

joelit avatar Dec 08 '21 11:12 joelit

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 08 '21 11:12 sonarqubecloud[bot]

Codecov Report

Merging #1257 (d686d6e) into master (e7f3bef) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1257   +/-   ##
=========================================
  Coverage     68.85%   68.85%           
  Complexity     1627     1627           
=========================================
  Files            32       32           
  Lines          3994     3994           
=========================================
  Hits           2750     2750           
  Misses         1244     1244           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f3bef...d686d6e. Read the comment docs.

codecov[bot] avatar Dec 08 '21 11:12 codecov[bot]

There is also a static, modified copy of twig-gettext-extractor under tools/twig-gettext-extractor. If we want to excise it completely, that should probably be removed too (which would also remove the tools directory as it's the only file there).

osma avatar Feb 11 '22 15:02 osma